What's one of the ugliest piece of code you've written so far?
Patrik Kiss
Posted on December 19, 2019
We have all written ugly code so far, that's a fact. Some are just bad, some are worse. And some other ones are just disgusting. Naturally, I'm no exception either.
For me, it's probably this one(prepare yourself):
function S1E23(){
document.getElementById("Season3div").style.display="none";
document.getElementById("Season4div").style.display="none";
document.getElementById("director").style.display="block";
document.getElementById("directorname").innerHTML="<a target=blank href=https://www.imdb.com/name/nm0236173/?ref_=tt_ov_dr>Dermott Downs</a>";
document.getElementById("episode23buttons").style.display="block";
document.getElementById("episode2buttons").style.display="none";
document.getElementById("episode3buttons").style.display="none";
document.getElementById("episode4buttons").style.display="none";
document.getElementById("episode5buttons").style.display="none";
document.getElementById("episode6buttons").style.display="none";
document.getElementById("episode7buttons").style.display="none";
document.getElementById("episode8buttons").style.display="none";
document.getElementById("episode9buttons").style.display="none";
document.getElementById("episode10buttons").style.display="none";
document.getElementById("episode11buttons").style.display="none";
document.getElementById("episode12buttons").style.display="none";
document.getElementById("episode13buttons").style.display="none";
document.getElementById("episode14buttons").style.display="none";
document.getElementById("episode15buttons").style.display="none";
document.getElementById("episode16buttons").style.display="none";
document.getElementById("episode17buttons").style.display="none";
document.getElementById("episode18buttons").style.display="none";
document.getElementById("episode19buttons").style.display="none";
document.getElementById("episode20buttons").style.display="none";
document.getElementById("episode21buttons").style.display="none";
document.getElementById("episode22buttons").style.display="none";
document.getElementById("episode1buttons").style.display="none";
document.getElementById("Season2div").style.display="none";
document.getElementById("Season1div").style.display="block";
document.getElementById("review").style.display="block";
document.getElementById("reviewlink").style.display="block";
document.getElementById("reviewlink").innerHTML="<a target=blank href=http://www.ign.com/articles/2015/05/20/the-flash-fast-enough-review>Read here</a>";
document.getElementById("trailer").style.display="block"
document.getElementById("promo").style.display="block"
document.getElementById("promo").innerHTML="<a target=blank href=https://www.youtube.com/watch?v=Qx90DwHjIvk>Watch here</a>";
document.getElementById("episodeinformation").style.display="block";
document.getElementById("episoderate").style.display="block";
document.getElementById("episodedate").style.display="block";
document.getElementById("episodelength").style.display="block";
document.getElementById("date").innerHTML="19 May 2015";
document.getElementById("star").style.display="block";
document.getElementById("length").innerHTML="44 min";
document.getElementById("ratenumber").innerHTML="9.6";
document.getElementById("episodeimage").src="s1e23.png";
document.getElementById("episodetitle").innerHTML = "<div id=episodetitle>Season 1 Episode 23:Fast Enough</div>";
document.getElementById("episodedescription").innerHTML="<p> Once the preparations were set for Barry to travel back in time,"+
" he traveled back to the night Nora died. However, despite this,"+
" Barry's alternative future self saw Barry and signaled him to not to interfere and proceeded"+
" to transport his younger self 20 blocks away.<br><br> Barry, in tears, obeyed. He spoke to Nora once last time,"+
" revealing his identity to her, and assured her that he and Henry are okay in the future."+
" In the present, Eobard gets into the time machine Cisco made,"+
" remarking that Rip Hunter first designed it.<br><br> Cisco warns him never to return."+
" Suddenly, a helmet with wings on top comes out of the wormhole, which Eobard takes as his signal to leave. "+
"However, Barry returns, destroying the time machine with a supersonic punch.</p>";
}
I'd written this back when I just started programming, I was a total beginner, and I made a static website about The Flash. Back then I'd thought it was really good, but now I obviously know it's not. It is seriously terrible, like for real.
And if it's not enough, I had repeated the function
above around 70 times, only changing 1 line, where I set the display
of the current episode to block
. Thus the JS file consisted of thousands of lines of ugly code.
It's your turn now, share the worst piece of code you have written so far :D
Posted on December 19, 2019
Join Our Newsletter. No Spam, Only the good stuff.
Sign up to receive the latest update from our blog.