How do you handle Code Reviews?
Stefan Stöhr
Posted on July 28, 2021
That’s the question I asked my colleagues and the result was, well … not so surprising.
Many teams have a chat channel where they post the link to their merge request.
If someone does a review for a MR, they add an eyes
👀 emoji to the message, if it’s approved they add a checkmark
✅ and if there are questions they add a speech bubble
💬 or cross mark
❌ .
Other teams only assign people directly in GitHub or GitLab and the ticket system.
And some do a mix of both of them (like my team). If nobody reacts to a MR in our chat, we pick one 🤗
What is interesting: In some teams the reviewer merges the MR, in others the person who wrote the code.
Pressing the merge button is a success experience and we wanted to leave that to the person who wrote the code
But you could also say: Who merges the code is responsible for breaking the pipeline 😅
So how are you doing it?
Message in a channel? Assigning your Team Lead? Or something completely different (drawing straws)? Let me know in the comments.
Posted on July 28, 2021
Join Our Newsletter. No Spam, Only the good stuff.
Sign up to receive the latest update from our blog.