Intro

For the last release, I have to work on something larger and more impactful than anything I have done in the previous three releases. This blog will be separated into 3 other blogs, Release 0.4 - Planning, Release 0.4 - Progress, and Release 0.4 - Release.
In this part, I will talk about creating a Pull Request, and fixing Pull request feedback.

Issues

In the previous post, we committed our code now let push all code to our remote by doing git push origin <branch>. Then create a Pull request

Issue #2418

Pull request #2551, for this pull request I added what issue it's fixed for + a description + a demo video, and check all checkboxes for my PR. I assigned humphd to be my reviewer. Finally, click on open Pull request to publish.

After that, it was time to wait for some approval or feedback.

I received some feedback.

• From manekenpix, is to change the path of fetch('/status') to fetch('/v1/status/status').
• From DukeManh, is to have better variable, reuse variable, and also return response earlier. I immediately adjusted, then commit my code and rebase + squash my commit, then pushed for re-review.
• From humphd, is to only show the services for the current deployment (i.e., staging or production, but not both at once). Because it is required some back-end having some variable I moved that issue to be fixed in Issue#2553. After getting all my approval I was finally able to merge it. After in staging, the API status broke, it wasn't working correctly. Because in staging/prod adds /v1/status, the URL for fetching turns into /v1/status/v1/status/status. So I immidiately created a Pull request #2579 and fixed that issue by changing

service.router.get('/v1/status/status', (req, res) => {

to

service.router.get(`${process.env.PATH_PREFIX || ''}/status`, (req, res) => {

Finally, after all this, my feature works in staging.

Issue #2506

Pull request #2518, for this pull request I added what issue it's fixed for + a description + a screenshot of the change, and check all checkboxes for my PR. I assigned humphd and Andrewnt219 to be my reviewers. Finally, click on open Pull request to publish.

Again, after that, it was time to wait for some approval or feedback.

I received some feedback.

• From humphd, is that the SHA need to be off from the name. I went back to my code and change it to have a font of monospaced, used .text-xs (to make it smaller), and .btn-link class (to have a different color). Then I committed, rebase it and push it to remote. After getting all my approval I was finally able to merge it.

Issue #113

Pull request #128, for this pull request I added what issue it's fixed for + a description. Finally, click on open Pull request to publish.

Again, after that, it was time to wait for some approval or feedback.

I received some feedback.

• From humphd, is to change

![5x5_2DArrayExample](https://cdn.discordapp.com/attachments/353432193730871296/911315058041171988/table_any.png)

to

![5x5_2DArrayExample](img/2d array.png)

I committed my change and pushed to the remote.
After getting all my approval I was finally able to merge it.

Conclusion

This is the whole process from a-z how to contribute to an open sources project.
Throughout the process, I learned more about code practice which is important to have clean code.