Code Smell 102 - Arrow Code

Nested IFs and Elses are very hard to read and test

TL;DR: Avoid nested IFs. Even Better: Avoid ALL IFs

Problems

Readability

Solutions

Extract Method
Combine Boolean Conditions
Remove accidental IFs

Context

In procedural code, it is very common to see complex nested ifs. This is more related to scripting than object-oriented programming.

Sample Code

Wrong

if (actualIndex < totalItems)
    {
      if (product[actualIndex].Name.Contains("arrow"))
      {
        do
        {
          if (product[actualIndex].price == null)
          {
            // handle no price
          }
          else
          {
            if (!(product[actualIndex].priceIsCurrent()))
            {
              // add price
            }
            else
            {
              if (!hasDiscount)
              {
                // handle discount
              }
              else
              {
                // etc
              }
            }
          }
          actualIndex++;
        }
        while (actualIndex < totalCounf && totalPrice < wallet.money);
      }
      else
        actualIndex++;
    }
    return actualIndex;
  }

Right

foreach (products as currentProduct)
  addPriceIfDefined(currentProduct)

addPriceIfDefined() 
{
  //Several extracts
}

Detection

[X] Automatic

Since many linters can parse trees we can check on compile-time for nesting levels.

Conclusion

Following uncle bob's advice, we should leave the code cleaner than we found it.

Refactoring this problem is easy.

Relations

Code Smell 78 - Callback Hell

Maxi Contieri ・ Jun 11 '21

#javascript #node #oop #tutorial

Code Smell 03 - Functions Are Too Long

Maxi Contieri ・ Oct 22 '20

#codenewbie #beginners #programming #100daysofcode

Code Smell 36 - Switch/case/elseif/else/if statements

Maxi Contieri ・ Nov 28 '20

#oop #webdev #tutorial #codenewbie

More Info

The purpose of software engineering is to control complexity, not to create it.

Pamela Zave

Software Engineering Great Quotes

Maxi Contieri ・ Dec 28 '20

#codenewbie #programming #quotes #software

This article is part of the CodeSmell Series.

How to Find the Stinky parts of your Code

Maxi Contieri ・ May 21 '21

#codenewbie #tutorial #codequality #beginners

Blog