Scenario

• I'm working on a big feature that I know can be broken into two parts
  • these parts are, as is often the case, dependent on each other.
• I branch off master and create branch feat/part1
• I finish coding part1, and create a PR with this branch
  • feat/part1 -> master
  • this is PR-1
• While I'm still checked out in feat/part1, I create a new branch feat/part2
• I finish coding part 2 and create a second, "stacked" PR
  • feat/part2 -> feat/part1.
  • this is PR-2

Let's say both PRs get reviewed and approved. I now merge PR-2.

• PR-1 now contains all the changes.

Question

• Can I assume that PR-1 is now approved and merge-able or do I need to re-review it?

Background

• As for why someone would do this, this technique of breaking up PRs is a way to breakup large changes into more manageable chunks
• That way the rest of the team can give feedback more easily.
• Can read more about it here: Stacked PRs To Keep Github Diffs Small | graysonkoonce.com